Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to K2, add Qodana #69

Merged
merged 8 commits into from
Aug 19, 2024
Merged

Conversation

Daoortor
Copy link
Collaborator

@Daoortor Daoortor commented Jul 25, 2024

Detekt is not yet supported in kotlin 2.0, so Qodana was added instead.

@Daoortor Daoortor requested review from GirZ0n, nbirillo and mikrise2 and removed request for GirZ0n July 25, 2024 19:54
Copy link
Collaborator

@mikrise2 mikrise2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

.github/workflows/qodana.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@nbirillo nbirillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So as I can see in the merged PR you have not updated the compiled sources in the server resources, please do it. Also the workflow has not been run...

@nbirillo nbirillo merged commit 2ab6f0e into jetbrains-academy:main Aug 19, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants