Adding solutions to pass tests #4
Conversation
There was a problem hiding this comment.
@anchouls thank you! Please, take a look at the comments. Let's do different tasks in different PRs, it will simplify the code review process a lot. For example, there is a separate task for README, you already added it here, so let's leave it here, but for the next time please submit your work in corresponding PRs.
| @@ -3,9 +3,9 @@ package jetbrains.refactoring.course.formatting | |||
| import java.io.File | |||
There was a problem hiding this comment.
Do we ask people to remove unused import in this task as well?
If it's a file with correct solution, there shouldn't be a line with unused import, right?
| placeholder_text: |- | ||
| package jetbrains.refactoring.course.formatting | ||
|
|
||
| import java.io.File |
There was a problem hiding this comment.
I'm a bit worried that we have the same text in different places. What if we change it in one place and forget to change in another one?
|
|
||
| Topics covered: | ||
|
|
||
| - refactoring definition; |
There was a problem hiding this comment.
Some topics are written from capital letter, some not...
README.md
Outdated
|
|
||
| ## Getting started | ||
|
|
||
| This course is available (TODO) on JetBrains Marketplace and can be installed from the |
There was a problem hiding this comment.
If it's not available yet, let's just don't write about it
README.md
Outdated
| git clone https://github.com/jetbrains-academy/refactoring-course.git | ||
| ``` | ||
|
|
||
| 2. Install [npm](https://www.npmjs.com/) and [yarn](https://yarnpkg.com/) on your computer. |
README.md
Outdated
|
|
||
| 2. Install [npm](https://www.npmjs.com/) and [yarn](https://yarnpkg.com/) on your computer. | ||
|
|
||
| 3. Run yarn install in each module with frontend. |
There was a problem hiding this comment.
I'm not sure about steps 2 and 3. I just build project and run Course preview action...
contributing.md
Outdated
| @@ -0,0 +1,46 @@ | |||
| # What this repository is | |||
|
|
|||
| This repository contains sources of the Refactoring course. | |||
There was a problem hiding this comment.
of the Refactoring in IDE course.
No description provided.