Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add course links for course plan #67

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Add course links for course plan #67

merged 2 commits into from
Nov 27, 2023

Conversation

Undin
Copy link
Contributor

@Undin Undin commented Nov 17, 2023

These changes add course links to course structure in the description of Introduction task

Before:

Just a plain text course structure

Screenshot 2023-11-17 at 17 22 36

After:
Interactive links to course items

Screen.Recording.2023-11-17.at.17.15.48.mov

@Geravant Geravant requested a review from onewhl November 17, 2023 16:48
@Geravant
Copy link
Contributor

@DaniilBogdanovJB , please, take a look at this

@DaniilBogdanovJB
Copy link

Hello,

Everything seems fine; links work as expected, only two links seems a bit off(Section 2:Lesson 2 and the last one):
image

@Undin
Copy link
Contributor Author

Undin commented Nov 21, 2023

Section 2:Lesson 2

It's because there isn't the corresponding lesson anymore. I've already asked the corresponding question above

the last one

Since we don't reference anything particular, I'm not sure that we should have link here. But if there are any ideas, I'm glad to discuss them

@onewhl onewhl merged commit 148fabb into main Nov 27, 2023
4 checks passed
@onewhl onewhl deleted the arseniy/course-links branch November 27, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants