Stop allowing configurable z and zo commands #109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
ghost
commented
Apr 8, 2022
| set -U ZO_CMD "$Z_CMD"o | ||
|
|
||
| if test ! -z $Z_CMD | ||
| function $Z_CMD -d "jump around" |
There was a problem hiding this comment.
I think jump around and open target dir (line 30 of this file), were the descriptions that were used by fish for the user-facing functions. I kept the one that was in __z.fish as it seems more complete, but if you want we can use these instead.
|
I've rebased on master. I think all that's left now is to regenerate the man pages. Do we have to do that manually? |
septatrix
reviewed
Jun 20, 2022
Comment on lines
-63
to
-65
| * `set -U Z_CMD "j"`: | ||
| Change commands to `j` and `jo` | ||
|
|
There was a problem hiding this comment.
Maybe explain somewhere that aliases can be made (preferably) with abbr or function --wraps
There was a problem hiding this comment.
Yeah that sounds good. I don't really have the time anymore to work on this though.
ghost
closed this by deleting the head repository
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements what we discussed here: #107 (comment). By moving to a static command we can ship the command and its completions in the format that fisher expects. This isn't just useful for fisher, it also works better with fish. By shipping static commands fish can lazy load both the commands and their completions. This means we don't have to run setup for this in conf.d scripts. It also simplifies the code a little bit.
Users can still easily create an alias fn, which is the canonical fish way of renaming a command. That way, even if they want to alias the command they can still retain the lazy loading.
Also, I took a look with grep.app, and could find only two users who were using a custom z command: see here. So this seems ok to change if we want to.