Release/0.4.8_i18n #840
Release/0.4.8_i18n #840
Conversation
|
|
|
ui/public/locales/en.json
Outdated
| @@ -0,0 +1 @@ | |||
| {} No newline at end of file | |||
There was a problem hiding this comment.
Is there a reason we don't put all the undisputed English stuff here, and the UK/US differences as overrides in their respective files? Are we actually doing fallback?
There was a problem hiding this comment.
current only en-US and zh-CN , if browser detect without language file , i18n-next will auto failback to en-US
why put empty language file ,
my browser language is zh-CN , but i18next auto request zh.json & zh-CN.json language file ,
in english(US) the same , i18next request both file (en.json & en-US.json)
just without 404 error
| @@ -0,0 +1,758 @@ | |||
| { | |||
There was a problem hiding this comment.
I personally do not feel qualified to review the Chinese (I could possibly do a reasonable job with German)... how do we get another Chinese person to chip in?
| <p className="mb-2 text-sm text-slate-600 dark:text-slate-300"> | ||
| A new update is available to enhance system performance and improve | ||
| compatibility. We recommend updating to ensure everything runs smoothly. | ||
| {t('A_new_update_is_available_to_enhance_system_performance_and_improve_compatibility_We_recommend_updating_to_ensure_everything_runs_smoothly')} |
There was a problem hiding this comment.
We should probably shorten huge keys like this.
There was a problem hiding this comment.
Yes, that's a good idea. but I can't decide which key replace with long sentences
There was a problem hiding this comment.
Just if it's more that 5 or six words, maybe?
| import tsconfigPaths from "vite-tsconfig-paths"; | ||
| import basicSsl from "@vitejs/plugin-basic-ssl"; | ||
|
|
||
| declare const process: { |
There was a problem hiding this comment.
Please revert this white-space/indentation-only change.
There was a problem hiding this comment.
emm .. why after commit with the white-space ??
There was a problem hiding this comment.
The file ends with three blank lines
There was a problem hiding this comment.
Thanks for starting this off!
We've discussed internally and would rather use InLang.com for our localization package as it gives a much better developer-experience and quite a bit smaller at runtime. It compiles messages into JS functions, which are fully typed so you cannot easily forget replacement parameters and such.
We know it's tedious to do this initial pass, and really appreciate your efforts. Can you switch from i18next to inlang or would you like to resubmit after we pull it in?
| @@ -135,4 +134,4 @@ | |||
| }; | |||
|
|
|||
| return ( | |||
There was a problem hiding this comment.
Please restore this code, it's fine if it's not localized.
add i18n support , add zh-CN language