Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

Commit

Permalink
Fixes some spelling and grammar in docs and flags
Browse files Browse the repository at this point in the history
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
  • Loading branch information
JoshVanL committed Jun 29, 2020
1 parent da5e757 commit 38d2ace
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
4 changes: 2 additions & 2 deletions cmd/app/options/app.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ func (k *KubeOIDCProxyOptions) AddFlags(fs *pflag.FlagSet) *KubeOIDCProxyOptions
"Port to expose readiness probe.")

fs.StringVar(&k.MetricsListenAddress, "metrics-serving-address", "0.0.0.0:80",
"Adress to serving metrics on at the /metrics path. An empty address will "+
"disable serving metrics.")
"Address to serve metrics on at the /metrics path. An empty address will "+
"disable serving metrics. Cannot use the same address as proxy or probe.")

fs.DurationVar(&k.FlushInterval, "flush-interval", time.Millisecond*50,
"Specifies the interval to flush request bodies. If 0ms, "+
Expand Down
3 changes: 2 additions & 1 deletion cmd/app/run.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ func buildRunCommand(stopCh <-chan struct{}, opts *options.Options) *cobra.Comma

// Initialise metrics handler
metrics := metrics.New()
// Add the metrics server as a shutdown hook
hooks.AddPreShutdownHook("Metrics", metrics.Shutdown)

// Initialise token reviewer if enabled
Expand Down Expand Up @@ -124,7 +125,7 @@ func buildRunCommand(stopCh <-chan struct{}, opts *options.Options) *cobra.Comma
return err
}
} else {
klog.Info("metrics listen address empty, disabling serving")
klog.Info("metrics listen address empty, disabling serving metrics")
}

// Run proxy
Expand Down
4 changes: 2 additions & 2 deletions docs/tasks/metrics.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,15 @@ The proxy exposes the following metrics:

### kube_oidc_proxy_http_client_requests
counter - {http status code, path, remote address}
The number of requests for incoming requests.
The number of incoming requests.

### kube_oidc_proxy_http_client_duration_seconds
histogram - {remote address}
The duration in seconds for incoming client requests to be responded to.

### kube_oidc_proxy_http_server_requests
counter - {http status code, path, remote address}
The requests for outgoing server requests.
The number of outgoing server requests.

### kube_oidc_proxy_http_server_duration_seconds
histogram - {remote address}
Expand Down

0 comments on commit 38d2ace

Please sign in to comment.