Remove omitempty from AnchorIgnoreIfNotPresent #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @jfcote87, thanks for this package.
I was trying to use anchor tags to position a signing tab, but I had a problem with "AnchorIgnoreIfNotPresent". I needed to use it as "false", but the json tag has "omitempy", which resulted in this property being removed from the payload. Then when the document is sent without the Anchor String it doesn't trigger an error (which is what this property is used for) and creates an envelope without any signing tab.
Removing the omitempty property fixes this issue.