Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed "Back-to-Top Button" Color "Issues" in Dark Mode and Added Button to All Pages #1358

Merged
merged 4 commits into from
Jun 23, 2024

Conversation

MastanSayyad
Copy link
Contributor

@MastanSayyad MastanSayyad commented Jun 20, 2024

Description

Hey @jfmartinz

This pull request addresses the following issues with the "Back to Top" button on the Resource Hub website:

  • Color Issue in Dark Mode: The "Back to Top" button had visibility issues in dark mode.
    • In light mode, the button was black with a white arrow, but in dark mode, it turned completely white, making it invisible.
    • This has been fixed so that in dark mode, the button is white with a black arrow.
    • Additionally, hover effects have been added for better user experience.
  • Button Availability on Resources Pages: The "Back to Top" button was only present on the main page. It has now been added to resource pages, to improve navigation. (the back to top button was specially needed for them)

Changes Made:

  • Updated the CSS for the "Back to Top" button to ensure it is visible
  • Light Mode: Black button with a white arrow.
  • Dark Mode: White button with a black arrow.
  • Added hover effects to the button for better visual feedback.
  • Integrated the "Back to Top" button into all resource pages for consistent navigation.

Screenshots

gotop.mp4

Please take a look and review it, thank you!

Type of change

  • Website enhancement or fixes

Checklist:

  • I read carefully CONTRIBUTING.md
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@jfmartinz
Copy link
Owner

jfmartinz commented Jun 21, 2024

Solve the conflict so I can merge this PR

@MastanSayyad
Copy link
Contributor Author

@jfmartinz conflicts are resolved

@MastanSayyad
Copy link
Contributor Author

Hey @jfmartinz please take a look and merge this PR

@jfmartinz
Copy link
Owner

Please resolve the conflict, thanks

@jfmartinz
Copy link
Owner

Sorry hehe

@MastanSayyad
Copy link
Contributor Author

Sorry hehe

I can see you knew what you did 😂😂

@MastanSayyad
Copy link
Contributor Author

Please resolve the conflict, thanks

Done @jfmartinz, Conflicts are resolved

@jfmartinz jfmartinz merged commit 96132cf into jfmartinz:main Jun 23, 2024
0 of 2 checks passed
Copy link

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

@jfmartinz
Copy link
Owner

Thanks @MastanSayyad as always. Your contributions are very helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants