Skip to content

Remove duplicate release creation from CI workflow#21

Merged
jfox85 merged 1 commit intomainfrom
jf-release-process
Oct 1, 2025
Merged

Remove duplicate release creation from CI workflow#21
jfox85 merged 1 commit intomainfrom
jf-release-process

Conversation

@jfox85
Copy link
Owner

@jfox85 jfox85 commented Oct 1, 2025

The ci.yml workflow was conflicting with the dedicated release.yml workflow, causing permission errors when both tried to create releases on tag pushes. Now release.yml (with GoReleaser) is the sole owner of release creation.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated CI to run only on non-tag pushes.
    • Removed automated release creation from tag events.
    • Maintained artifact retention at 7 days.
    • No user-facing functionality changes; app behavior remains the same.

The ci.yml workflow was conflicting with the dedicated release.yml workflow,
causing permission errors when both tried to create releases on tag pushes.
Now release.yml (with GoReleaser) is the sole owner of release creation.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@coderabbitai
Copy link

coderabbitai bot commented Oct 1, 2025

Walkthrough

The CI workflow was updated by removing tag-based triggers and deleting the release creation job that ran on tag references. Push events no longer include tags, and automated GitHub Releases are no longer created. Artifact upload remains with a 7-day retention setting.

Changes

Cohort / File(s) Summary
CI workflow triggers
.github/workflows/ci.yml
Removed push tag trigger (tags: ['v*']), limiting CI to non-tag pushes.
Release automation
.github/workflows/ci.yml
Deleted the release job using softprops/action-gh-release@v2 that ran on tag refs.
Artifacts configuration
.github/workflows/ci.yml
Retained retention-days: 7 in the artifact upload step; no other changes.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Dev as Developer
  participant GH as GitHub
  participant CI as CI Workflow

  Dev->>GH: Push commit (branch)
  GH-->>CI: Trigger workflow (push on branch)
  Note over CI: Build/Test jobs run<br/>(artifacts retained 7 days)

  Dev->>GH: Push tag (vX.Y.Z)
  GH--xCI: No trigger (tag push removed)
  Note over GH,CI: Release job removed<br/>No GitHub Release created
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I hop through YAML fields at night,
Snipping tag-hooks out of sight—
No release carrots on this run,
Just builds and tests ’til jobs are done.
Seven moons to stash the loot,
Then off I bounce—nimble, astute. 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title accurately and concisely describes the primary change in the CI workflow by stating that duplicate release creation is being removed, which directly reflects the deletion of the tag-based trigger and release job in ci.yml to defer releases to the dedicated workflow.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jf-release-process

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/ci.yml (1)

91-95: Unreachable tag branch in version detection

Line 91 still checks for refs/tags/v*, but CI no longer runs on tag pushes, so this branch will never execute. Simplify to avoid dead code.

Apply this diff to streamline the logic:

-        if [[ $GITHUB_REF == refs/tags/v* ]]; then
-          VERSION=${GITHUB_REF#refs/tags/}
-        else
-          VERSION=$(git describe --tags --always --dirty)
-        fi
+        VERSION=$(git describe --tags --always --dirty)
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 262ff37 and 9481dff.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Build
  • GitHub Check: Build

@jfox85 jfox85 merged commit 8db8a29 into main Oct 1, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant