Fix port matching false positive in server discovery#26
Conversation
Use strings.HasSuffix instead of strings.Contains to prevent ports like :8080 from being incorrectly matched as the :80 server. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
discoverServerName()usingstrings.Contains(addr, ":80")which would incorrectly match:8080,:8081, etc.strings.HasSuffixinstead for exact port matching:8080false positive caseFollow-up to #25 based on CodeRabbit review feedback.
Test plan
:8080server is not matched,:80server is correctly selected🤖 Generated with Claude Code