Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle invalid payloads and content types #14

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

jfrconley
Copy link
Owner

Problem

Unhelpful error is thrown when request body cannot be parsed using the given content-type

Solution

Add new NornirParseError class which is thrown when body cannot be parsed

closes #11

Testing

run normal test suite

Copy link

changeset-bot bot commented Dec 1, 2023

🦋 Changeset detected

Latest commit: df1d865

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@nornir/rest Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 1, 2023

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 16.61% 93/560
🔴 Branches 6.15% 11/179
🔴 Functions 25.17% 37/147
🔴 Lines 17.76% 92/518

Test suite run success

14 tests passing in 3 suites.

Report generated by 🧪jest coverage report action from df1d865

@jfrconley jfrconley merged commit 45c6dbf into main Dec 1, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better handling of GET requests that contain content-type header
1 participant