Skip to content

Commit

Permalink
Upgrade default jfrog-cli to v1.46.1
Browse files Browse the repository at this point in the history
  • Loading branch information
@eyalbe4
eyalbe4 committed Apr 12, 2021
1 parent 52a63c7 commit 4950580
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions artifactory-tasks-utils/utils.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ const toolName = 'jfrog';
const btPackage = 'jfrog-cli-' + getArchitecture();
const jfrogFolderPath = encodePath(path.join(tl.getVariable('Agent.ToolsDirectory') || '', '_jfrog'));
const jfrogLegacyFolderPath = encodePath(path.join(tl.getVariable('Agent.WorkFolder') || '', '_jfrog'));
const defaultJfrogCliVersion = '1.42.3';
const defaultJfrogCliVersion = '1.46.1';
const minCustomCliVersion = '1.37.1';
const pluginVersion = '1.11.4';
const pluginVersion = '1.11.5';
const buildAgent = 'artifactory-azure-devops-extension';
const customFolderPath = encodePath(path.join(jfrogFolderPath, 'current'));
const customCliPath = encodePath(path.join(customFolderPath, fileName)); // Optional - Customized jfrog-cli path.
Expand Down

7 comments on commit 4950580

@lindhe
Copy link

@lindhe lindhe commented on 4950580 Apr 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WTF are you doing? It's not released yet: https://jfrog.bintray.com/jfrog-cli-go/

This is breaking our CI. Revert this immediately.

Screenshot from 2021-04-13 08-51-09

@lindhe
Copy link

@lindhe lindhe commented on 4950580 Apr 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eyalbe4 URGENT

@eyalbe4
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lindhe -
New JFrog CLI releases are not release to Bintray for a while now.
You haven't provided a lot of information as part of this issue, but I assime you're using the Artifactory Tools Installer task as part of your Azure DevOps pipeline. Please go ahead and modify the JFrog CLI download URL (and if needed the build-info extractors URL) to the new download locations, as described here.
Please let us know if you need further assistance with this.

@lindhe
Copy link

@lindhe lindhe commented on 4950580 Apr 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why on earth is such a breaking change not communicated to paying customers?

@Dauit
Copy link

@Dauit Dauit commented on 4950580 Apr 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had the same issue, look like they changed the repo for where to fetch the CLI from. But yeah, we had the same issue.
These kind of changes is quite hard to notice...

In version 48 of the docs https://www.jfrog.com/confluence/display/JFROG/Artifactory+Azure+DevOps+Extension they changed it from https://jfrog.bintray.com/jfrog-cli-go/ to https://releases.jfrog.io/artifactory/jfrog-cli/v1/

@lindhe
Copy link

@lindhe lindhe commented on 4950580 Apr 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the answer, Dauit.

@Dauit
Copy link

@Dauit Dauit commented on 4950580 Apr 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to clean the cache for the repo cuz it still fetched the old broken one all of the time;
https://yourcompany/#/artifacts/browse/tree/General/jfrog-cli-local-cache

Please sign in to comment.