Skip to content

Conversation

@reshmifrog
Copy link
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • Appropriate label is added to auto generate release notes.
  • I used gofmt for formatting the code before submitting the pull request.
  • PR description is clear and concise, and it includes the proposed solution/fix.

Added workflow to run cli e2e testcases.

@reshmifrog reshmifrog added the improvement Automatically generated release notes label Jan 20, 2026
@reshmifrog reshmifrog added the safe to test Approve running integration tests on a pull request label Jan 20, 2026
push:
branches:
- main
- master
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we just have main branch in this repo, no point in keeping both

repository: ${{ github.event.pull_request.head.repo.full_name || github.repository }}
ref: ${{ github.event.pull_request.head.sha || github.sha }}

- name: Detect replace directives
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a direct golang command for replace directives
go mod edit -replace ://github.com

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to replace all the dependencies with their forked branch in jfrog-cli, if branch not found, replace with master or leave it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see goTests and NugetTests are missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Automatically generated release notes safe to test Approve running integration tests on a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants