Skip to content

Upgrade to Java 17, Tycho 3.0.0 and plugins common 2.4.0 #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kerenr-jfrog merged 5 commits into from
Mar 24, 2025
Merged

Upgrade to Java 17, Tycho 3.0.0 and plugins common 2.4.0 #28

kerenr-jfrog merged 5 commits into from
Mar 24, 2025

Conversation

@kerenr-jfrog
Copy link
Contributor

@kerenr-jfrog kerenr-jfrog commented Mar 23, 2025 •
edited
Loading

  • Upgraded Java version from 8 to 17 in order to support upgrade of the plugins common library.
  • Upgraded Tycho version to 3.0.0 to be compliant with Java 17.
  • Upgraded plugins common dependency to version 2.3.6.
  • Adjusted project structure and code in order to be compliant with the plugins common version 2.4.0.
  • Removed dedicated package managers scan managers files as they will no longer be needed since the plugin will run the JFrog CLI for scanning projects.

@kerenr-jfrog kerenr-jfrog marked this pull request as ready for review March 23, 2025 18:12
@kerenr-jfrog kerenr-jfrog self-assigned this Mar 23, 2025
@kerenr-jfrog kerenr-jfrog added the dependencies Pull requests that update a dependency file label Mar 23, 2025
attiasas
attiasas reviewed Mar 24, 2025
View reviewed changes
Copy link

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of TODO and comments left

@kerenr-jfrog
Copy link
Contributor Author

kerenr-jfrog commented Mar 24, 2025

This code has been pushed to the V2 branch and will be used by @eyalk007 and myself to implement the new version of the plugin in parallel.

@kerenr-jfrog kerenr-jfrog changed the title Upgrade to Java 17, Tycho 3.0.0 and plugins common 2.3.6 Upgrade to Java 17, Tycho 3.0.0 and plugins common 2.4.0 Mar 24, 2025
@kerenr-jfrog kerenr-jfrog merged commit ed2de56 into jfrog:V2 Mar 24, 2025
1 check passed
@kerenr-jfrog kerenr-jfrog deleted the upgrade_java_and_dependencies branch March 24, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@attiasas attiasas attiasas left review comments

@eyalk007 eyalk007 Awaiting requested review from eyalk007

+1 more reviewer

@hadarshjfrog hadarshjfrog hadarshjfrog left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kerenr-jfrog kerenr-jfrog

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kerenr-jfrog @attiasas @hadarshjfrog