Skip to content

Add Tests Automation & Upgrade Test Project to Java 17 #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kerenr-jfrog merged 18 commits into from
Jun 4, 2025
Merged

Add Tests Automation & Upgrade Test Project to Java 17 #37

kerenr-jfrog merged 18 commits into from
Jun 4, 2025

Conversation

@kerenr-jfrog
Copy link
Contributor

@kerenr-jfrog kerenr-jfrog commented Apr 14, 2025 •
edited
Loading

  • Added tests workflow for automating running test before merging new code.
  • Added Pull Request template for consistency and better documentation.
  • Upgraded tests project to Java 17, ensuring compatibility with the project environment.
  • Removed outdated test code related to the old plugin implementation to improve maintainability.

@kerenr-jfrog kerenr-jfrog changed the title Add tests Add tests workflow May 19, 2025
@kerenr-jfrog kerenr-jfrog changed the title Add tests workflow Add Tests Automation & Upgrade to Java 17 May 19, 2025
@kerenr-jfrog kerenr-jfrog changed the title Add Tests Automation & Upgrade to Java 17 Add Tests Automation & Upgrade Test Project to Java 17 May 19, 2025
@kerenr-jfrog kerenr-jfrog requested review from attiasas and eyalk007 May 19, 2025 09:11
@kerenr-jfrog kerenr-jfrog self-assigned this May 19, 2025
@kerenr-jfrog kerenr-jfrog added the ignore for release Ignore for release label May 19, 2025
@kerenr-jfrog kerenr-jfrog marked this pull request as ready for review May 19, 2025 09:12
@kerenr-jfrog kerenr-jfrog requested a review from hadarshjfrog May 21, 2025 07:53
attiasas
attiasas requested changes May 27, 2025
View reviewed changes
Copy link

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!, is upgrading to Java 17 introduces limitations?

@kerenr-jfrog kerenr-jfrog requested a review from attiasas June 4, 2025 12:40
@kerenr-jfrog kerenr-jfrog merged commit 8c461bb into jfrog:master Jun 4, 2025
1 check passed
@kerenr-jfrog kerenr-jfrog deleted the add_tests branch June 4, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eyalk007 eyalk007 Awaiting requested review from eyalk007

@hadarshjfrog hadarshjfrog Awaiting requested review from hadarshjfrog

@attiasas attiasas Awaiting requested review from attiasas

Assignees

@kerenr-jfrog kerenr-jfrog

Labels

ignore for release Ignore for release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kerenr-jfrog @attiasas