Added WebviewManager and CefBrowser #42
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| addSection("Location:", "row: " + node.getRowStart() + " col: " + node.getColStart()); | ||
| addSection("Reason:", node.getReason()); | ||
| if (webviewManager == null || !webviewManager.isReady()) { | ||
| log.warn("WebviewManager not ready. Cannot display issue."); |
There was a problem hiding this comment.
not ready means we're waiting for something - are we waiting? doing a retry after some time? otherwise - let's alter the message
bundle/src/main/java/com/jfrog/ide/eclipse/ui/issues/ComponentIssueDetails.java
Outdated
Show resolved
Hide resolved
bundle/src/main/java/com/jfrog/ide/eclipse/ui/issues/ComponentIssueDetails.java
Outdated
Show resolved
Hide resolved
| private Frame frame; | ||
|
|
||
| // State management | ||
| private final AtomicBoolean browserInitialized = new AtomicBoolean(false); |
There was a problem hiding this comment.
why do we need AtomicBoolean instead of boolean?
if there's a purpose - please explain it here
bundle/src/main/java/com/jfrog/ide/eclipse/ui/webview/WebviewManager.java
Show resolved
Hide resolved
bundle/src/main/java/com/jfrog/ide/eclipse/ui/webview/WebviewManager.java
Show resolved
Hide resolved
bundle/src/main/java/com/jfrog/ide/eclipse/ui/webview/WebviewManager.java
Show resolved
Hide resolved
bundle/src/main/java/com/jfrog/ide/eclipse/ui/webview/WebviewManager.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.