Skip to content

Improve source code scanners logging #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Conversation

talarian1
Copy link
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

The scanner's run logs will now be logged in the IDE log instead of in a dedicated log file.
If an error occurs the log level is INFO, otherwise DEBUG.

@talarian1 talarian1 added the ignore for release Automatically generated release notes label Sep 11, 2023
@talarian1 talarian1 added the safe to test Approve running integration tests on a pull request label Sep 11, 2023
yahavi
yahavi previously approved these changes Sep 12, 2023
@yahavi yahavi dismissed their stale review September 12, 2023 04:26

Should be "request changes"

@yahavi
Copy link
Member

yahavi commented Sep 12, 2023

I think this change should be considered an "improvement" and not "ignore for release".

@talarian1 talarian1 added improvement Automatically generated release notes and removed ignore for release Automatically generated release notes labels Sep 12, 2023
@talarian1 talarian1 merged commit 318d728 into jfrog:master Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes safe to test Approve running integration tests on a pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants