Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ERR_ABORTED when opening links #416

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Fix ERR_ABORTED when opening links #416

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/main/java/com/jfrog/ide/idea/ui/webview/WebviewManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,11 @@ public void onLoadEnd(CefBrowser browser, CefFrame frame, int httpStatusCode) {
@Override
public void onLoadError(CefBrowser browser, CefFrame frame, ErrorCode errorCode, String errorText, String failedUrl) {
super.onLoadError(browser, frame, errorCode, errorText, failedUrl);
// When opening links in external browser, JBCef cancels the page redirection and opens the page in a new browser window.
// This cancelation causes CEF to throw an ERR_ABORTED error.
if (errorCode == ErrorCode.ERR_ABORTED) {
return;
}
Logger.getInstance().error("An error occurred while opening the issue details view: " + errorText);
}
}, jbCefBrowser.getCefBrowser());
Expand Down
Loading