Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for jetbrains ides #475

Merged

Conversation

eyalk007
Copy link
Contributor

@eyalk007 eyalk007 commented Aug 27, 2024

  • [ X] All tests passed. If this feature is not already covered by the tests, I added new tests.

added the dependencies to fix the support for Pycharm, Webstorm, Goland and Android Studio.
upgraded node version to 20 in Github as Darwin(mac os) does not support node 14.

@eyalk007 eyalk007 requested a review from hadarshjfrog August 27, 2024 10:58
@eyalk007 eyalk007 self-assigned this Aug 27, 2024
@eyalk007 eyalk007 added the bug Something isn't working label Aug 27, 2024
@eyalk007 eyalk007 linked an issue Aug 27, 2024 that may be closed by this pull request
@hadarshjfrog hadarshjfrog added the safe to test Approve running integration tests on a pull request label Aug 27, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 27, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Aug 27, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 27, 2024
@eranturgeman
Copy link

Change the label to 'new feature' as it is a new ability

@eranturgeman eranturgeman self-requested a review August 27, 2024 11:32
@eranturgeman
Copy link

Please do not combine several tasks in one PR, even if it will make you open 3 different PRs with a single line each.
You fixed a bug, added new feature and updated version in a yml file. these are 3 different and unrelated tasks.
Dont forget this is an OPEN SOURCE project. Every Pr must be clear what it contains and what it changes, and contain only changes related to a single task (think what will happen if we need to revert this commit - all of your work will be lost even if only 1 thing from this PR caused an issue).
This is also important to reflect our work correctly in the release notes. This PR will go under "bug fixes" even when it contains a new ability, of will go under "new features" when it suggest a fix for an issue, that customers might be miss this fix

Copy link

@eranturgeman eranturgeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refer to my comments

@eyalk007 eyalk007 added the new feature Automatically generated release notes label Aug 27, 2024
@eranturgeman
Copy link

Please write in detail exactly what ides you added support to. If you didn't check all ides (what does it even mean? there are plenty of IDES we doesn't support at all) so we cannot make this commitment. If you did check them one by one please list their names

@eranturgeman eranturgeman removed the new feature Automatically generated release notes label Aug 27, 2024
removed unnecessary from plugin.xml
@eyalk007 eyalk007 force-pushed the feature/add-support-for-jetbrains-ides branch from f32550f to 65a22ea Compare August 27, 2024 12:14
@eyalk007 eyalk007 changed the title Feature/add support for jetbrains ides fix support for supported jetbrains ides Aug 27, 2024
@eranturgeman eranturgeman changed the title fix support for supported jetbrains ides Fix support for jetbrains ides Aug 27, 2024
Copy link

@eranturgeman eranturgeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Aug 27, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 27, 2024
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.


@eyalk007 eyalk007 merged commit c806179 into jfrog:master Aug 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants