Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the title for warnings in webview #482

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Fixed the title for warnings in webview #482

merged 1 commit into from
Sep 12, 2024

Conversation

eyalk007
Copy link
Contributor

@eyalk007 eyalk007 commented Sep 12, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

The title in the webview became the description. this obviously isn't good for anything as it is not the right pararmater.

@eyalk007
Copy link
Contributor Author

after fix
image

@attiasas attiasas added bug Something isn't working safe to test Approve running integration tests on a pull request labels Sep 12, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 12, 2024
@eyalk007
Copy link
Contributor Author

before fix
image

@eyalk007 eyalk007 self-assigned this Sep 12, 2024
@eyalk007 eyalk007 changed the title fixed the title in webview Fixed the title in of warnings in webview Sep 12, 2024
attiasas
attiasas approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eyalk007
Copy link
Contributor Author

image original bug is still solved

reference here #481

@eyalk007 eyalk007 changed the title Fixed the title in of warnings in webview Fixed the title for warnings in webview Sep 12, 2024
@github-actions GitHub Actions
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.

@eyalk007 eyalk007 merged commit 3525d07 into jfrog:master Sep 12, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attiasas attiasas attiasas approved these changes

Assignees

@eyalk007 eyalk007

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eyalk007 @attiasas