Skip to content
This repository was archived by the owner on Jun 4, 2023. It is now read-only.

Add os matrix to workflow #3

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add os matrix to workflow #3

wants to merge 4 commits into from

Conversation

@aquacash5
Copy link

@aquacash5 aquacash5 commented Sep 15, 2020 •
edited
Loading

I think the linting check should be run on all latest os options.

After having some issues getting the Windows and macOS checks to pass, I ended up re-implementing other aspects of the action. Including changing the file append routine to use the fs module instead of using the shell.

Changes

  • Adds os matrix to test action on all latest os options
  • Adds a test procedure to ensure the .npmrc file was correctly modified
  • Adds dist/index.js to eslint and prettier ignore
  • Replace shell execution with fs module for modifying the .npmrc file

aquacash5 and others added 4 commits September 15, 2020 18:14
@aquacash5
Add os matrix to workflow
9a68f3f
@aquacash5
Add pull request
9d52089
Fix lint errors
7404db4
@aquacash5
File append using fs
fd95512 
- Action to use the fs module instead of depending on the OS
- New compiled version in the `dist` directory as recommended by
  https://docs.github.com/en/actions/creating-actions/creating-a-javascript-action#commit-tag-and-push-your-action-to-github
- Tests the functionality of action in ci.yml
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@aquacash5