Skip to content

Comments

add-eb-global-support#400

Merged
jgilbert01 merged 5 commits intomasterfrom
add-eb-global-support
Apr 30, 2025
Merged

add-eb-global-support#400
jgilbert01 merged 5 commits intomasterfrom
add-eb-global-support

Conversation

@jgilbert01
Copy link
Owner

No description provided.


return {
...batchUow,
[publishRequestField]: endpointId ? /* istanbul ignore next */ {

This comment was marked as outdated.

.map((uow) => uow[publishRequestEntryField]),
...(endpointId && {
EndpointId: endpointId,
}),
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • jumping thru a hoop here with this condition to keep unit tests backwards compatible
  • otherwise it will be necessary to assert EndpointId: undefined in many tests

@petermyers
Copy link
Collaborator

If we're in the middle of a failover and the publishing is failing, is that considered a retryable error? So in theory it would bypass faulting and retry until the failover is complete and we can continue publishing to the global EB?
I think right now its checking based on the smithy error classifications and we use:
(isThrottlingError(err) || isTransientError(err) || isServerError(err))

@jgilbert01
Copy link
Owner Author

If we're in the middle of a failover and the publishing is failing, is that considered a retryable error? So in theory it would bypass faulting and retry until the failover is complete and we can continue publishing to the global EB? I think right now its checking based on the smithy error classifications and we use: (isThrottlingError(err) || isTransientError(err) || isServerError(err))

  • right
  • global endpoint is powered by r53 primary/secondary failover
  • our retry feature is not enabled by default for backwards compatibility
  • when enabled the lambda will retry retriable errors, such as 5xx, instead of publishing faults
  • the regional failover will usually take about 5 minutes to avoid premature failover
  • then the events will flow to the secondary region

@jgilbert01 jgilbert01 merged commit 8772eef into master Apr 30, 2025
2 checks passed
@jgilbert01 jgilbert01 deleted the add-eb-global-support branch April 30, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants