Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blazor] Added one to many, many to many and enum support for blazor front #478

Merged
merged 18 commits into from
Dec 6, 2020

Conversation

nicolas63
Copy link
Member

related to #165

@sonarcloud
Copy link

sonarcloud bot commented Dec 6, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ivanmonteiro
Copy link
Contributor

Ok.
I have found that working with disconnected entities with EF Core tends to be tricky and unexpected errors can and most likely will happen.

Yes me too, do you want us to change that ?

For now we use what is already implemented.
Add a plan to change from detached-entities in the near future. To"attached" entities, where the framework does the change tracking. This (hopefully) should make development and customization of repository layer easier. The added cost is extra queries at save/update. As always, some consideration and feedback from other developers and community are welcome. @nicolas63 Should a new issue be created to discuss it?

If possible, create an application with entities and relationships set up, and manually creating new entities with the UI and set the relationships. Also update the records using the UI, by un-checking the dropbox/checkbox of the relationship. And check if the changes were properly persisted.

Yes, i have try with https://github.com/jhipster/jhipster-dotnetcore/blob/main/test-integration/samples/jdl-default/app.jdl who don't works today and now all operation is ok

I will push the blazor sample with relationships after the merge if you want try it

Go ahead and merge when you're ready

@nicolas63
Copy link
Member Author

For now we use what is already implemented.
Add a plan to change from detached-entities in the near future. To"attached" entities, where the framework does the change tracking. This (hopefully) should make development and customization of repository layer easier. The added cost is extra queries at save/update. As always, some consideration and feedback from other developers and community are welcome. @nicolas63 Should a new issue be created to discuss it?

yes, i think work on #355 who can help us because we can work only with id rather than complete structure

@nicolas63 nicolas63 merged commit fd7ffb7 into jhipster:main Dec 6, 2020
@ivanmonteiro
Copy link
Contributor

For now we use what is already implemented.
Add a plan to change from detached-entities in the near future. To"attached" entities, where the framework does the change tracking. This (hopefully) should make development and customization of repository layer easier. The added cost is extra queries at save/update. As always, some consideration and feedback from other developers and community are welcome. @nicolas63 Should a new issue be created to discuss it?

yes, i think work on #355 who can help us because we can work only with id rather than complete structure

Yes, you're right!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants