Skip to content

Commit

Permalink
Merge pull request #410 from mshima/allopen
Browse files Browse the repository at this point in the history
drop allopen plugin options
  • Loading branch information
DanielFran authored Jul 30, 2024
2 parents e75bcf3 + 5220966 commit 34c99dc
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 36 deletions.
13 changes: 1 addition & 12 deletions generators/kotlin/__snapshots__/generator.spec.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,6 @@ exports[`SubGenerator kotlin of kotlin JHipster blueprint > gradle > should matc
"pluginName": "kotlin-jpa",
"version.ref": "kotlin",
},
{
"addToBuild": true,
"id": "org.jetbrains.kotlin.plugin.allopen",
"pluginName": "kotlin-allopen",
"version.ref": "kotlin",
},
],
"addGradleDependencyCatalogPlugins": [
[
Expand Down Expand Up @@ -244,12 +238,7 @@ exports[`SubGenerator kotlin of kotlin JHipster blueprint > maven > should match
<plugin>spring</plugin>
<plugin>jpa</plugin>
<plugin>all-open</plugin>
</compilerPlugins><pluginOptions>
<!-- Each annotation is placed on its own line -->
<option>all-open:annotation=javax.persistence.Entity</option>
<option>all-open:annotation=javax.persistence.MappedSuperclass</option>
<option>all-open:annotation=javax.persistence.Embeddable</option>
</pluginOptions>
</compilerPlugins>
</configuration>
<dependencies>
<dependency>
Expand Down
17 changes: 1 addition & 16 deletions generators/kotlin/generator.js
Original file line number Diff line number Diff line change
Expand Up @@ -120,12 +120,6 @@ export default class extends BaseApplicationGenerator {
'version.ref': 'kotlin',
addToBuild: true,
});
source.addGradleDependencyCatalogPlugin({
pluginName: 'kotlin-allopen',
id: 'org.jetbrains.kotlin.plugin.allopen',
'version.ref': 'kotlin',
addToBuild: true,
});
}
}
}
Expand Down Expand Up @@ -302,16 +296,7 @@ export default class extends BaseApplicationGenerator {
<plugin>all-open</plugin>`
: ''
}
</compilerPlugins>${
application.databaseTypeSql
? `<pluginOptions>
<!-- Each annotation is placed on its own line -->
<option>all-open:annotation=javax.persistence.Entity</option>
<option>all-open:annotation=javax.persistence.MappedSuperclass</option>
<option>all-open:annotation=javax.persistence.Embeddable</option>
</pluginOptions>`
: ''
}
</compilerPlugins>
</configuration>
<dependencies>
<dependency>
Expand Down
8 changes: 0 additions & 8 deletions generators/kotlin/templates/gradle/kotlin.gradle.ejs
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,6 @@ kapt {
correctErrorTypes true
}

<%_ if (databaseTypeSql) { _%>
allOpen {
annotation("javax.persistence.Entity")
annotation("javax.persistence.MappedSuperclass")
annotation("javax.persistence.Embeddable")
}
<%_ } _%>
[compileKotlin, compileTestKotlin]*.with {
kotlinOptions {
jvmTarget = "<%= javaVersion %>"
Expand Down

0 comments on commit 34c99dc

Please sign in to comment.