Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update workflow for v8 base #384

Merged
merged 1 commit into from
Jul 24, 2024
Merged

update workflow for v8 base #384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 4 additions & 19 deletions .github/workflows/angular.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,29 +113,14 @@ jobs:
#----------------------------------------------------------------------
# Detect changes against base commit
#----------------------------------------------------------------------
# Revert samples rename to old name.
- uses: actions/setup-node@v4
with:
node-version: 16
- name: 'MERGE: generate base'
continue-on-error: true
id: base-app
- uses: jhipster/actions/compare-sample@v0
id: compare
if: >-
github.event.pull_request &&
!contains(github.event.pull_request.labels.*.name, 'pr: disable-compare')
uses: ./jhipster-kotlin/.github/actions/compare-base
with:
extra-args: '--skip-jhipster-dependencies --skip-ktlint-format ${{ matrix.extra-args }}'
- name: 'MERGE: compare changes'
continue-on-error: true
id: compare
if: steps.base-app.outcome == 'success'
uses: ./jhipster-kotlin/.github/actions/compare
with:
application-path: ${{ steps.base-app.outputs.application-path }}
- uses: actions/setup-node@v4
with:
node-version: 20
generator-path: jhipster-kotlin
cmd: cli.cjs generate-sample --skip-jhipster-dependencies --skip-install --skip-ktlint-format ${{ matrix.extra-args }}
#----------------------------------------------------------------------
# Launch tests
#----------------------------------------------------------------------
Expand Down
23 changes: 4 additions & 19 deletions .github/workflows/react.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,29 +113,14 @@ jobs:
#----------------------------------------------------------------------
# Detect changes against base commit
#----------------------------------------------------------------------
# Revert samples rename to old name.
- uses: actions/setup-node@v4
with:
node-version: 16
- name: 'MERGE: generate base'
continue-on-error: true
id: base-app
- uses: jhipster/actions/compare-sample@v0
id: compare
if: >-
github.event.pull_request &&
!contains(github.event.pull_request.labels.*.name, 'pr: disable-compare')
uses: ./jhipster-kotlin/.github/actions/compare-base
with:
extra-args: '--skip-jhipster-dependencies --skip-ktlint-format ${{ matrix.extra-args }}'
- name: 'MERGE: compare changes'
continue-on-error: true
id: compare
if: steps.base-app.outcome == 'success'
uses: ./jhipster-kotlin/.github/actions/compare
with:
application-path: ${{ steps.base-app.outputs.application-path }}
- uses: actions/setup-node@v4
with:
node-version: 20
generator-path: jhipster-kotlin
cmd: cli.cjs generate-sample --skip-jhipster-dependencies --skip-install --skip-ktlint-format ${{ matrix.extra-args }}
#----------------------------------------------------------------------
# Launch tests
#----------------------------------------------------------------------
Expand Down
Loading