Merge pull request #10996 from qmonmert/sonar270924

Sonar: 8 issues

src/main/webapp/app/module/domain/landscape/Landscape.ts

@@ -491,7 +491,6 @@ class LevelsProjections {
       levels
         .flatMap(level => level.elements)
         .filter(element => element instanceof LandscapeFeature)
-        .map(feature => feature as LandscapeFeature)
         .map(feature => [feature.slugString(), feature]),
     );
   }

src/main/webapp/app/module/primary/landscape/BodyCursorUpdater.ts

@@ -1,7 +1,7 @@
 import { CursorType } from '@/module/primary/landscape/CursorType';
 
 export class BodyCursorUpdater {
-  constructor(private window: Window) {}
+  constructor(private readonly window: Window) {}
 
   set(cursorType: CursorType) {
     this.window.document.body.style.cursor = cursorType;

src/main/webapp/app/module/primary/landscape/LandscapeNavigation.ts

@@ -8,8 +8,8 @@ export class LandscapeNavigation {
   private currentModule: number;
   private currentElement: number;
   private currentLevel: number;
-  private landscapeElements: Map<string, HTMLElement>;
-  private levels: LandscapeLevel[];
+  private readonly landscapeElements: Map<string, HTMLElement>;
+  private readonly levels: LandscapeLevel[];
 
   constructor(landscapeElements: Map<string, HTMLElement>, levels: LandscapeLevel[]) {
     [this.currentLevel, this.currentElement, this.currentModule] = this.setValues(0, 0, 0);

src/main/webapp/app/module/secondary/RestModulesRepository.ts

@@ -19,7 +19,7 @@ import { RestModuleToApply, toRestModuleToApply } from './RestModuleToApply';
 import { mapToModuleHistory, RestProjectHistory } from './RestProjectHistory';
 
 export class RestModulesRepository implements ModulesRepository {
-  constructor(private axiosInstance: AxiosHttp) {}
+  constructor(private readonly axiosInstance: AxiosHttp) {}
 
   list(): Promise<Modules> {
     return this.axiosInstance.get<RestModules>('/api/modules').then(mapToModules);

src/main/webapp/app/module/secondary/RestProjectFoldersRepository.ts

@@ -3,7 +3,7 @@ import { AxiosHttp } from '@/shared/http/infrastructure/secondary/AxiosHttp';
 import { ProjectFolder } from '../domain/ProjectFolder';
 
 export class RestProjectFoldersRepository implements ProjectFoldersRepository {
-  constructor(private axiosInstance: AxiosHttp) {}
+  constructor(private readonly axiosInstance: AxiosHttp) {}
 
   get(): Promise<ProjectFolder> {
     return this.axiosInstance.get<ProjectFolder>('/api/project-folders').then(res => res.data);

src/main/webapp/app/shared/alert/infrastructure/secondary/MittAlertBus.ts

@@ -4,7 +4,7 @@ import { AlertType } from '@/shared/alert/infrastructure/secondary/AlertType';
 import { Emitter } from 'mitt';
 
 export class MittAlertBus implements AlertBus {
-  constructor(private emitter: Emitter<any>) {}
+  constructor(private readonly emitter: Emitter<any>) {}
 
   success(alert: AlertMessage): void {
     this.emitter.emit(AlertType.SUCCESS, alert);

src/main/webapp/app/shared/alert/infrastructure/secondary/MittAlertListener.ts

@@ -6,7 +6,7 @@ import { AlertType } from '@/shared/alert/infrastructure/secondary/AlertType';
 import { Emitter, Handler } from 'mitt';
 
 export class MittAlertListener implements AlertListener {
-  constructor(private emitter: Emitter<any>) {}
+  constructor(private readonly emitter: Emitter<any>) {}
 
   onSuccess(alerted: Alerted): Unsubscribe {
     const handler: Handler<AlertMessage> = message => alerted(message);