Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix upgrade dependency org.apache.pulsar:pulsar-client to v3.3.2 #11077

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −3
Open

Fix upgrade dependency org.apache.pulsar:pulsar-client to v3.3.2 #11077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ...h/jhipster/lite/generator/server/springboot/broker/pulsar/domain/PulsarModuleFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ public class PulsarModuleFactory {

private static final JHipsterSource SOURCE = from("server/springboot/broker/pulsar");

private static final String PULSAR = "pulsar";

private static final String PULSAR_CONFIG = "wire/pulsar/infrastructure/config";

private final DockerImages dockerImages;
Expand All @@ -45,7 +47,8 @@ public JHipsterModule buildModule(JHipsterModuleProperties properties) {
.put("pulsarDockerImage", dockerImages.get("apachepulsar/pulsar").fullName())
.and()
.javaDependencies()
.addDependency(groupId("org.apache.pulsar"), artifactId("pulsar-client"), versionSlug("pulsar"))
.addDependency(groupId("org.apache.pulsar"), artifactId("pulsar-client"), versionSlug(PULSAR))
.addDependency(groupId("org.apache.pulsar"), artifactId("pulsar-client-api"), versionSlug(PULSAR))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed? This is not mentioned in the official documentation: https://pulsar.apache.org/docs/3.3.x/client-libraries-java-setup/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't find a better solution for the moment

.addDependency(testContainerDependency())
.and()
.files()
Expand Down Expand Up @@ -77,7 +80,7 @@ public JHipsterModule buildModule(JHipsterModuleProperties properties) {
private JavaDependency testContainerDependency() {
return javaDependency()
.groupId("org.testcontainers")
.artifactId("pulsar")
.artifactId(PULSAR)
.versionSlug("testcontainers")
.scope(JavaDependencyScope.TEST)
.build();
Expand Down
7 changes: 6 additions & 1 deletion src/main/resources/generator/dependencies/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<kafka-clients.version>3.8.0</kafka-clients.version>
<mongock.version>5.4.4</mongock.version>
<neo4j-migrations.version>2.13.1</neo4j-migrations.version>
<pulsar.version>3.3.1</pulsar.version>
<pulsar.version>3.3.2</pulsar.version>
<liquibase.version>4.29.2</liquibase.version>
<reflections.version>0.10.2</reflections.version>
<json-web-token.version>0.12.6</json-web-token.version>
Expand Down Expand Up @@ -347,6 +347,11 @@
<artifactId>pulsar-client</artifactId>
<version>${pulsar.version}</version>
</dependency>
<dependency>
<groupId>org.apache.pulsar</groupId>
<artifactId>pulsar-client-api</artifactId>
<version>${pulsar.version}</version>
</dependency>
<dependency>
<groupId>com.approvaltests</groupId>
<artifactId>approvaltests</artifactId>
Expand Down
5 changes: 5 additions & 0 deletions ...ipster/lite/generator/server/springboot/broker/pulsar/domain/PulsarModuleFactoryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,11 @@ void shouldBuildModule() {
<artifactId>pulsar-client</artifactId>
<version>${pulsar.version}</version>
</dependency>
<dependency>
<groupId>org.apache.pulsar</groupId>
<artifactId>pulsar-client-api</artifactId>
<version>${pulsar.version}</version>
</dependency>
"""
)
.containing(
Expand Down