Add Axios Http into generated Vue Webapp #1588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matthieuRioual
commented
May 4, 2022
matthieuRioual
commented
- Related to Vue: account with authentication JWT #897
Codecov Report
@@ Coverage Diff @@
## main #1588 +/- ##
============================================
Coverage 100.00% 100.00%
+ Complexity 1655 1626 -29
============================================
Files 355 340 -15
Lines 5836 5705 -131
Branches 141 129 -12
============================================
- Hits 5836 5705 -131
Continue to review full report at Codecov.
|
pascalgrimaud
requested changes
May 5, 2022
| @@ -12,7 +13,8 @@ | |||
| "devDependencies": { | |||
| "@pinia/testing": "0.0.11", | |||
| "@rushstack/eslint-patch": "1.1.3", | |||
| "@types/jest": "27.4.1", | |||
| "@types/jest": "27.5.0", | |||
| "@types/sinon": "^10.0.11", | |||
There was a problem hiding this comment.
Remove ^, always use fixed version
|
some conflicts to resolve too |
|
Plz, as mentioned above, remove the useless additional file: kuregreg, then squash and rebase to resolve conflict |
pascalgrimaud
requested changes
May 9, 2022
| @Operation(summary = "Add JWT to Vue+Pinia application", description = "Add JWT to Vue+Pinia application") | ||
| @ApiResponse(responseCode = "500", description = "An error occurred while adding JWT to your vue application") | ||
| @PostMapping("/jwt") | ||
| @GeneratorStep(id = GeneratorAction.VUE_STYLED) |
| "vue-tsc": "0.34.11" | ||
| } | ||
| } | ||
| "name": "jhlite-dependencies", |
pascalgrimaud
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.