Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put landscape in light #4088

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Put landscape in light #4088

merged 1 commit into from
Oct 25, 2022

Conversation

Gnuk
Copy link
Collaborator

@Gnuk Gnuk commented Oct 24, 2022

This PR put landscape in light style, it's a step to have less coupling on font and colors during the migration to Tikui.

@Gnuk
Copy link
Collaborator Author

Gnuk commented Oct 24, 2022

Maybe @DamnClin and @pascalgrimaud, you may see if all colors still visible for each cases.

@pascalgrimaud
Copy link
Member

Can you add a little screenshot plz?

@Gnuk
Copy link
Collaborator Author

Gnuk commented Oct 24, 2022

Here is a screen:

Screenshot_20221024_163300

@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (866f8ed) compared to base (674943e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##                main     #4088   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      2159      2159           
===========================================
  Files            572       572           
  Lines           9317      9317           
  Branches         181       181           
===========================================
  Hits            9317      9317           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nassimerrahoui nassimerrahoui mentioned this pull request Oct 24, 2022
@DamnClin
Copy link
Collaborator

All visible but the grey looks more active than the white to me so I have a strange feeling :D (and it's very white....)

@pascalgrimaud
Copy link
Member

LGTM, can it be merged, @Gnuk @DamnClin ?

@DamnClin
Copy link
Collaborator

LGTM, can it be merged, @Gnuk @DamnClin ?

Ok for me

@Gnuk
Copy link
Collaborator Author

Gnuk commented Oct 25, 2022

It's ok, we will change it later using the chip I imagine cc @nassimerrahoui on #4089 and later :p

@pascalgrimaud pascalgrimaud merged commit 379d93e into jhipster:main Oct 25, 2022
@Gnuk Gnuk deleted the landscape-light branch October 25, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants