起動パラメータでポート番号設定対応、IPv6対応 #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimflip
reviewed
Sep 4, 2024
server.js
Outdated
| @@ -12,7 +12,8 @@ const userDataMap = new Map(); // 名前と出来事を記録するマップ | |||
| * APIリクエストを処理する | |||
| */ | |||
| Deno.serve({ | |||
| port: 8080, | |||
| port: Deno.args[0] || 8080, | |||
There was a problem hiding this comment.
大きく影響はないかと思いますがnull合体演算子を使った方が良さそうです(yamajiくんから教えてもらいました)
https://developer.mozilla.org/ja/docs/Web/JavaScript/Reference/Operators/Nullish_coalescing
There was a problem hiding this comment.
たしかに、?? のほうがいいね
ポート番号 0 を指定できないバグになりますね
|
問題なく起動できることを確認しましたLGTM👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
VPS上で起動できるようにするため、起動ポートを設定したい
関連
#59
テスト方法
レビュアーチェックリスト