Skip to content

Commit

Permalink
[Discover] Adjust log.level indicator alignment (elastic#195098)
Browse files Browse the repository at this point in the history
##  📓 Summary

A change in the EuiDataGrid style clashed with a custom CSS change
applied to the grid in order to render the `log.level` indicator on the
whole line height.

This change fixes the spacing issue and delegates to the inner element,
the indicator itself, the responsibility to make fill the whole space
ignoring padding imposed by the grid (using an absolute positioning, the
DOM node will ignore inner spacing and fill the parent container.)



https://github.com/user-attachments/assets/fe8d418a-5c7f-4999-86a4-296304d5aa97

Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>
  • Loading branch information
tonyghiani and Marco Antonio Ghiani authored Oct 7, 2024
1 parent 89f2802 commit 78cc1ad
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ const ColorIndicatorCell: React.FC<ColorIndicatorCellParams> = ({ getRowIndicato
data-test-subj="unifiedDataTableRowColorIndicatorCell"
title={label}
css={css`
position: absolute;
top: 0;
background: ${color};
width: ${COLOR_INDICATOR_WIDTH}px;
height: 100%;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@
}
.euiDataGridRowCell.euiDataGridRowCell--controlColumn[data-gridcell-column-id='colorIndicator'] .euiDataGridRowCell__content {
height: 100%;
padding: 0;
border-bottom: 0;
}

Expand Down

0 comments on commit 78cc1ad

Please sign in to comment.