forked from elastic/kibana
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Discover] [ES|QL] Disables sorting for Document view (elastic#187553)
## Summary Disables the `@timestamp` sorting for ES|QL Document view. The sorting doesnt work currently. I could enable it but this causes 2 problems: - The fix is here https://github.com/elastic/kibana/blob/main/packages/kbn-unified-data-table/src/components/data_table.tsx#L962 The timestamp column is a special column for Discover so the columns.length is 0 here even if the timestamp column is being rendered. As a result the inMemory is false and the client side sorting doesnt work. Removing the columns.length fixes it but it makes Discover significantly slower. - As the data are not by default sorted by timestamp even if we enable it client side, it won't be of great help. I think that for the timestamp column it would be better to enable server side sorting but this needs discussion I think that hiding this for now it will fix the confusion and is a good temporary decision before we decide what to do with sorting in general.
- Loading branch information
Showing
3 changed files
with
10 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters