Skip to content

Adding limit to history #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Adding limit to history #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b86bfcf
Adding optional limit to history call
churleya Jul 19, 2019
c6a28d3
Bumping version
churleya Jul 19, 2019
85f9cd9
Tidying up
churleya Jul 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions get-history-list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ module.exports = bottle => bottle.service( 'getHistoryList', getHistoryList,
'restClient',
'apiUrls'
)
function getHistoryList( restClient, apiUrls ) {
function getHistoryList( restClient, apiUrls, limit ) {

class HistoryItem {

Expand All @@ -47,9 +47,9 @@ function getHistoryList( restClient, apiUrls ) {
}
}

return async() => {
return async( limit ) => {
const historyListUrl = apiUrls.doorbots().history()
const historyItems = await restClient.authenticatedRequest( 'GET', historyListUrl )
const historyItems = await restClient.authenticatedRequest( 'GET', `${historyListUrl}?limit=${limit || 20}` )

return historyItems.map( h => new HistoryItem( h ))
}
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ring-api",
"version": "3.0.7",
"version": "3.0.8",
"description": "Unofficial API for ring doorbells and other devices",
"main": "main.js",
"dependencies": {
Expand Down