Skip to content

ch07 notebook: code fix + typo #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ch07 notebook: code fix + typo #158

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3982859
Fixes a couple typos in ch07 code
ArnaudBrousseau Aug 2, 2019
3edaddd
Switch second cell's parsing to target testnet. Fixes a 404/crash on …
ArnaudBrousseau Aug 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions code-ch07/Chapter7.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"from io import BytesIO\n",
"raw_tx = ('0100000001813f79011acb80925dfe69b3def355fe914bd1d96a3f5f71bf8303c6a989c7d1000000006b483045022100ed81ff192e75a3fd2304004dcadb746fa5e24c5031ccfcf21320b0277457c98f02207a986d955c6e0cb35d446a89d3f56100f4d7f67801c31967743a9c8e10615bed01210349fc4e631e3624a545de3f89f5d8684c7b8138bd94bdd531d2e213bf016b278afeffffff02a135ef01000000001976a914bc3b654dca7e56b04dca18f2566cdaf02e8d9ada88ac99c39800000000001976a9141c4bc762dd5423e332166702cb75f40df79fea1288ac19430600')\n",
"stream = BytesIO(bytes.fromhex(raw_tx))\n",
"transaction = Tx.parse(stream)\n",
"transaction = Tx.parse(stream, testnet=True)\n",
"print(transaction.fee() >= 0)"
]
},
Expand Down Expand Up @@ -153,14 +153,14 @@
"source": [
"from ecc import PrivateKey\n",
"from helper import SIGHASH_ALL\n",
"z = transaction.sig_hash(0)\n",
"z = tx_obj.sig_hash(0)\n",
"private_key = PrivateKey(secret=8675309)\n",
"der = private_key.sign(z).der()\n",
"sig = der + SIGHASH_ALL.to_bytes(1, 'big')\n",
"sec = private_key.point.sec()\n",
"script_sig = Script([sig, sec])\n",
"transaction.tx_ins[0].script_sig = script_sig \n",
"print(transaction.serialize().hex())"
"tx_obj.tx_ins[0].script_sig = script_sig \n",
"print(tx_obj.serialize().hex())"
]
},
{
Expand Down Expand Up @@ -274,7 +274,7 @@
"from tx import TxIn, TxOut, Tx\n",
"\n",
"# Create 2 TxIns, 1 from the Exercise 4 and 1 from a testnet faucet\n",
"# Creat 1 TxOut to the address above\n",
"# Create 1 TxOut to the address above\n",
"target_address = 'mwJn1YPMq7y5F8J3LkC5Hxg9PHyZ5K4cFv'\n",
"\n",
"# get the private key from the exercise in Chapter 4\n",
Expand Down