-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add bv_test and pre-commit hook #28
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
调用command的函数实现单元测试,有些错误可能测试不出来,感觉需要修改download函数里的一些逻辑。。。还有测试下载合集还需要找到一些比较好的测试用例 |
特定类型的报错可以不区分,先保证每次能下载正常就行了
随手找了几个可以用来测试的(也可以找更短的),season 可以再找一组 - self.media_id = "69361944"
- self.sid = "1855309" # 需要找到一个较少的测试合集,不然测起来时间太久了
- self.uid = "261485584" # 需要找到一个作品少的uid进行测试
+ self.test_series_uid = "25876945"
+ self.test_series_sid = "273179"
+ self.uid = "16"
这个可以我来修一下 |
Signed-off-by: jingfelix <jingfelix@outlook.com>
Signed-off-by: jingfelix <jingfelix@outlook.com>
Signed-off-by: jingfelix <jingfelix@outlook.com>
看起来是能连上的,可能得加超时和重连 |
Signed-off-by: jingfelix <jingfelix@outlook.com>
Signed-off-by: jingfelix <jingfelix@outlook.com>
Changelog:
|
jingfelix
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#27
只实现了测试bv下载的功能,实在不太清楚这种功能测试该怎么写
然后添加了pre-commit-hook 在提交前进行test检测