Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid xmlstring builder toString #1118

Merged
merged 3 commits into from
Oct 27, 2023

Conversation

bgrozev
Copy link
Member

@bgrozev bgrozev commented Oct 26, 2023

  • chore: Update jitsi-xmpp-extensions.
  • log: Remove System.err logs.
  • fix: Avoid using XmlStringBuilder.toString.

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #1118 (1937951) into master (ef49650) will decrease coverage by 0.02%.
The diff coverage is 8.06%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1118      +/-   ##
============================================
- Coverage     27.88%   27.86%   -0.02%     
  Complexity      473      473              
============================================
  Files           128      128              
  Lines          7779     7783       +4     
  Branches       1064     1064              
============================================
  Hits           2169     2169              
- Misses         5338     5342       +4     
  Partials        272      272              
Files Coverage Δ
.../kotlin/org/jitsi/jicofo/rest/ConferenceRequest.kt 0.00% <ø> (ø)
...c/main/java/org/jitsi/jicofo/xmpp/BaseBrewery.java 0.00% <0.00%> (ø)
.../kotlin/org/jitsi/jicofo/conference/Participant.kt 52.76% <0.00%> (ø)
...n/kotlin/org/jitsi/jicofo/jibri/JibriSipGateway.kt 16.66% <0.00%> (ø)
...n/org/jitsi/jicofo/xmpp/AuthenticationIqHandler.kt 0.00% <0.00%> (ø)
...ain/kotlin/org/jitsi/jicofo/xmpp/JibriIqHandler.kt 0.00% <0.00%> (ø)
...in/kotlin/org/jitsi/jicofo/xmpp/JigasiIqHandler.kt 71.07% <75.00%> (ø)
...mmon/src/main/kotlin/org/jitsi/jicofo/xmpp/Util.kt 0.00% <0.00%> (ø)
...tlin/org/jitsi/jicofo/xmpp/jingle/JingleSession.kt 0.00% <0.00%> (ø)
...i/jicofo/conference/ParticipantInviteRunnable.java 50.63% <0.00%> (-0.33%) ⬇️
... and 10 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef49650...1937951. Read the comment docs.

}

@Override
public void onOutgoingStreamElement(TopLevelStreamElement streamElement)
{
logger.debug(() -> "SENT PKT (" + id + "): " + streamElement.toXML());
logger.debug(
() -> "SENT PKT (" + id + "): " + XmlStringBuilderUtil.Companion.toStringOpt(streamElement.toXML())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If your method in jitsi-xmpp-extensions were on Element rather than ExtensionElement this could just use the non-companion flavor of toStringOpt -- is it worth it? (I think it clearly would be if this were Kotlin, but it's less obvious for Java.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this was awkward, but I didn't think it's worth another jitsi-xmpp-extensions update

@bgrozev bgrozev merged commit 067e575 into jitsi:master Oct 27, 2023
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants