OTP 26 fixes #10
Merged
OTP 26 fixes #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`:put_expand_no_trim` is sent from `:group` when needing to expand history for searching. Without this change, any matching history line is ignored and not output.
fhunleth
approved these changes
Jul 15, 2023
fhunleth
reviewed
Jul 15, 2023
In OTP 26 requires explicitly defining `expand_below: false` when starting the group and defaults to expanding below the prompt line. [`ssh_cli.erl` now defaults to `expand_below: false`](erlang/otp@81562f7#diff-d1641a7f3fc9ba8d592c295bc91b373637dd6660ea95a8441f501df3792642f7) and so this change matches that setting since expanding below is currently not supported. This is the current behavior in previous OTP versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also erlang/otp#7499