Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimal change to avoid a numpy deprecation failure. Without this #55

Merged
merged 5 commits into from
Feb 22, 2024
Merged

Minimal change to avoid a numpy deprecation failure. Without this #55

merged 5 commits into from
Feb 22, 2024

Conversation

bnlawrence
Copy link

All tests fail at python 3.10 and numpy 1.24.4. With it, they all pass.

Minimal change to avoid a numpy deprecation failure. Without this
e5d85fd 
all tests fail at python 3.10 and numpy 1.24.4. With it, they all pass.
@kmuehlbauer
Copy link
Collaborator

@bnlawrence Shall the build matrix be updated, here? (with python 3.11, python 3.12)

Bryan Lawrence added 2 commits February 22, 2024 09:17
Temporary class to explore the use of the chunk index, and
473fa36 
eventually, hopefully, address both the needs of
pyactivestorage (which needs access to the b-tree
chunk index) and jjhelmus#6
Temporary file for use while constructing functionalit.
3ee8f25 
Will turn into a test at some point.
@kalvdans
Copy link

Remove your play code from the pull request. Post it as comments intead.

@bnlawrence
Copy link
Author

Oh, sorry, I forgot that it would end up in the pull request because I did it on master. My bad. Will get that done later today (in meetings now).

@bnlawrence
Copy link
Author

Ok, I think that's clean on master now. Sorry about the noise.

@bnlawrence
Copy link
Author

@bnlawrence Shall the build matrix be updated, here? (with python 3.11, python 3.12)

I've not tested it on them yet. If we can do what we're trying to do, we will need to test it properly, and we can get back to that.

@bmaranville bmaranville self-requested a review February 22, 2024 13:12
bmaranville
bmaranville approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@bmaranville bmaranville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the PR!

@jjhelmus
Copy link
Owner

LGTM, thanks for the fix.

@jjhelmus jjhelmus merged commit d21662e into jjhelmus:master Feb 22, 2024
3 checks passed
@jjhelmus
Copy link
Owner

Shall the build matrix be updated, here? (with python 3.11, python 3.12)
Including newer Python versions in the test matrix is a good idea. I'll submit a PR adjusting this later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmuehlbauer kmuehlbauer kmuehlbauer approved these changes

@bmaranville bmaranville bmaranville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bnlawrence @kmuehlbauer @kalvdans @jjhelmus @bmaranville