Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a note when not using firefox #79

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Add a note when not using firefox #79

merged 2 commits into from
Jan 5, 2024

Conversation

keckelt
Copy link
Member

@keckelt keckelt commented Jan 5, 2024

When launched from browsers other than firefox, the following modal is displayed:

image

The modal will be shown when:

  • the browser is not firefox, AND
  • the loops sidebar is visible, AND
  • a notebook is opened, AND
  • if it has not be shown before.

@keckelt keckelt added the enhancement New feature or request label Jan 5, 2024
@keckelt keckelt self-assigned this Jan 5, 2024
@keckelt keckelt marked this pull request as ready for review January 5, 2024 09:57
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2024

Binder 👈 Launch a Binder on branch jku-vds-lab/loops/ff-disclaimer

@keckelt keckelt merged commit 5630051 into main Jan 5, 2024
6 checks passed
@keckelt keckelt deleted the ff-disclaimer branch January 5, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@keckelt keckelt

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@keckelt