Top players by place of birth #466
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces functionality to display top MLB players by WAR for a given nationality or U.S. state. The changes include the addition of documentation, a new module for processing birthplace statistics, and a function to display the top players.
Documentation:
docs/birthplace_stats.md: Added documentation for thedisplay_top_players_with_statsfunction, including arguments, available nationalities and state codes, and examples of valid queries.Code Implementation:
pybaseball/birthplace_stats.py: Introduced a new module with a dictionary mapping nationalities and state codes to their respective URLs, aBirthplaceHTMLTableProcessorclass for extracting tabular data, and aBaseballReferenceProcessorclass to retrieve top players by WAR. Additionally, added thedisplay_top_players_with_statsfunction to display and optionally save the top players by WAR for a given nationality.