Add video thumbnails to the reciple display pages #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-flower-0c3edd710-377.centralus.2.azurestaticapps.net |
|
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-flower-0c3edd710-377.centralus.2.azurestaticapps.net |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes multiple changes to the codebase, focusing on removing GitVersion setup, updating the data service, and adding new functionalities for handling video URLs. The most important changes are listed below:
Removal of GitVersion Setup:
.github/workflows/azure-static-web-apps-delightful-flower-0c3edd710.yml: Removed steps for installing and determining GitVersion, as well as setting the version number in.env.GitVersion.yml: Deleted the GitVersion configuration file.Data Service Updates:
src/services/dataService.ts: Added a new functiongetRecipeMediaUrlto fetch the media URL and updated the existinggetRecipeMediafunction to remove filtering by type.Handling Video URLs:
src/helpers/videoHelpers.ts: Added a new functiongetThumbnailto generate YouTube video thumbnails and refactoredprepareUrlForEmbedto use thegetVideoIdhelper function. [1] [2]Component Updates:
src/components/RecipeCard.vue: Added adata-testidattribute to the recipe image for better testability.src/components/RecipeList.vue: Updated to usegetRecipeMediaUrlinstead ofgetRecipeMediafor fetching recipe images. [1] [2]src/pages/recipe/[id]/print.vue: Updated to usegetRecipeMediaUrlinstead ofgetRecipeMediafor fetching recipe images. (src/pages/recipe/[id]/print.vueL6-R6, src/pages/recipe/[id]/print.vueL60-R67)Test Updates:
tests/edit.spec.ts: Added a new test to verify that video media shows the correct thumbnail.Issues
Closes #369