Using new flags from config pkg in osctrl-api
#628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javuto
added
refactor
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the osctrl-api service to utilize the new flags from the config package, ensuring consistency with recent configuration updates.
- Introduces a new function (InitAPIFlags) to initialize API-specific flags.
- Updates API configuration types in handlers, auth, and settings to use the unified JSONConfigurationService type.
- Adjusts settings loading to match the new configuration structure.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/config/flags.go | Added InitAPIFlags to assemble the API service flags from various flag categories. |
| cmd/api/handlers/handlers.go | Changed the ApiConfig field to use JSONConfigurationService instead of JSONConfigurationAPI. |
| cmd/api/auth.go | Modified handlerAuthCheck to accept auth and jwtSecret parameters and updated token check. |
| pkg/settings/settings.go | Updated SetAPIJSON to work with JSONConfigurationService instead of JSONConfigurationAPI. |
| pkg/config/types.go | Removed the obsolete JSONConfigurationAPI type. |
| cmd/api/settings.go | Adjusted loadingSettings to pass the new configuration type to settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete the refactor in
osctrl-apito utilize the flags from the new config pkg. It follows up the work in #622 #625 and #627