Feat/tests #23
Merged
Feat/tests #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this will need to be rebased. |
|
Ill fix the conflicts but let me know if these tests make any sense the app itself if simple enough that i was on the fence. |
stvnksslr
force-pushed
the
feat/tests
branch
from
26818c8 to
4d8a005
Compare
|
Yeah I think it's great. Only suggestion I have is, since you're already testing the healthcheck endpoint, you could test the output of /metrics instead of testing |
|
o thats a good point, i didnt think of that since its a big ole text blob |
…arning with the casing of as -> AS
jmriebold
reviewed
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not sure if needed to be merged, exploring building out some simple test cases.