Skip to content

Commit

Permalink
Don't convert Nan to zero.
Browse files Browse the repository at this point in the history
Converting Nan to zero is a bad idea because it makes it hard to tell when
something went wrong.
  • Loading branch information
comfyanonymous committed Nov 3, 2023
1 parent ee74ef5 commit ae2acfc
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions comfy/samplers.py
Original file line number Diff line number Diff line change
Expand Up @@ -136,10 +136,10 @@ def cond_cat(c_list):

def calc_cond_uncond_batch(model_function, cond, uncond, x_in, timestep, max_total_area, model_options):
out_cond = torch.zeros_like(x_in)
out_count = torch.zeros_like(x_in)
out_count = torch.ones_like(x_in) * 1e-37

out_uncond = torch.zeros_like(x_in)
out_uncond_count = torch.zeros_like(x_in)
out_uncond_count = torch.ones_like(x_in) * 1e-37

COND = 0
UNCOND = 1
Expand Down Expand Up @@ -239,9 +239,6 @@ def calc_cond_uncond_batch(model_function, cond, uncond, x_in, timestep, max_tot
del out_count
out_uncond /= out_uncond_count
del out_uncond_count

torch.nan_to_num(out_cond, nan=0.0, posinf=0.0, neginf=0.0, out=out_cond) #in case out_count or out_uncond_count had some zeros
torch.nan_to_num(out_uncond, nan=0.0, posinf=0.0, neginf=0.0, out=out_uncond)
return out_cond, out_uncond


Expand Down

0 comments on commit ae2acfc

Please sign in to comment.