Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enumerator values #176

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Enumerator values #176

merged 2 commits into from
Aug 10, 2023

Conversation

jnikula
Copy link
Owner

@jnikula jnikula commented Aug 6, 2023

Implement #175

If the enumerator is explicitly initialized in source, provide the
initializer value also in the Sphinx C and C++ domain directives.
@BrunoMSantos
Copy link
Collaborator

I like the default, I only think this may benefit from not expanding pre-processor constants, at least in some cases, kind of like in #174 for array sizes. Can be seen as an improvement though, so I wouldn't block it as it currently stands. Good to go!

@jnikula
Copy link
Owner Author

jnikula commented Aug 10, 2023

I like the default, I only think this may benefit from not expanding pre-processor constants, at least in some cases, kind of like in #174 for array sizes. Can be seen as an improvement though, so I wouldn't block it as it currently stands. Good to go!

Agreed! Thanks!

@jnikula jnikula merged commit ac4402d into master Aug 10, 2023
4 checks passed
@jnikula jnikula deleted the enumerator-values branch August 10, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants