Docker updates #238
Merged
Docker updates #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not really sure if this is the right thing to do, but seemed to work.
Fedora rawhide seems to have the latest of everything, including clang, so it's a good environment for testing. Ubuntu is of course very common.
Shorter, and reflects the idea better.
Bash completion figures out the targets from the Makefile, but ignores implicit/pattern rules. Add some magic to create real docker-test.* and docker-html.* targets to get proper autocompletion.
Using git archive to transfer files to the docker images means uncommitted modifications aren't transfered. It can be confusing if the modifications aren't reflected in the results. Fail with a warning message if the working directory is not clean.
|
I can always learn something at least ;) And yeah, this looks good and useful! It would have saved me some time on the last PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting up an environment to test clang 18 in a container, I stumbled on some issues with the docker test stuff. Fix them.
@BrunoMSantos Not sure if you care much about reviewing these kind of changes.