Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fetch channel webhooks method #28

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add fetch channel webhooks method #28

wants to merge 4 commits into from

Conversation

imptype
Copy link
Contributor

@imptype imptype commented Sep 21, 2023

No description provided.

@jnsougata jnsougata added the help wanted Extra attention is needed label Oct 10, 2023
@jnsougata
Copy link
Owner

jnsougata commented Oct 10, 2023 •
edited
Loading

Link method to channel as well i.e. PartialChannel.fetch_webhooks()

jnsougata
jnsougata requested changes Oct 12, 2023
View reviewed changes
Copy link
Owner

@jnsougata jnsougata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will result in a circular import. Rather return the raw payload for now

jnsougata
jnsougata requested changes Nov 16, 2023
View reviewed changes
Copy link
Owner

@jnsougata jnsougata left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove redundant client import and return the response directly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnsougata jnsougata jnsougata requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imptype @jnsougata