-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added option for notes when queueing cocktails #480
Conversation
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
…-queued-cocktail # Conflicts: # components/modals/CocktailDetailModal.tsx
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as personally discussed
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sometimes the wrong iteration of a cocktail gets deleted out of the queue when using the "x"
First you put in queue some number of e.g. margaritas and give them a note, then you add a few without any notes using the "Liste" or the "mit Notiz" button. Then when trying to delete a drink without a note using the red x in the queue it will delete a drink with a note instead of the one without any notes. This makes it impossible to delete any non-note drinks without clearing any previously added drinks with notes.
The same happens when having two iterations of a drink with notes and then adding a third one without notes
Any noted-drinks you add afterwards however will work fine. Adding noted drinks and trying to delete them will also work
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
Well spotted, thank you very much – it should now be fixed. :) |
# [1.10.0](v1.9.7...v1.10.0) (2025-01-07) ### Bug Fixes * Added add cocktail rating to cocktail ratings modal ([a6f909a](a6f909a)) * Alert z-index ([4012a27](4012a27)) * Search model open card behavior ([e589174](e589174)) ### Features * Added field for cocktail history notes and allowed numbers in tags ([#497](#497)) ([bb1a17d](bb1a17d)) * Added option for notes when queueing cocktails ([#480](#480)) ([b87a6b9](b87a6b9)) * Export cocktail as PDF ([#474](#474)) ([c424941](c424941)) * Tag suggestions ([#472](#472)) ([39584dc](39584dc))
🎉 This PR is included in version 1.10.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Closing issues:
Before you mark this PR as ready, please check the following points
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.
pnpm format:check
, if invalidpnpm format:fix
)pnpm build
)Describe your work, what changed
Adding Cocktails with Notes to the Queue:
Queue Behavior:
Behavior of the "Made" Button (e.g., Search, Cocktail Card, or Detail View):
Affected sites (please check during review):