Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Made long notes, history, and description fields collapsible #503

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jo-gross
Copy link
Owner

@jo-gross jo-gross commented Jan 9, 2025

Closing issues:

Before you mark this PR as ready, please check the following points

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I´e created all necessary migrations?
  • The format is correct (pnpm format:check, if invalid pnpm format:fix)
  • No build errors (pnpm build)
  • I´ve tested the implemented function by my own
  • Ensure the pr title fits the conventional commit standard

Describe your work, what changed

By having long notes, descriptions or history texts, the layout got destroyed pretty fast. To prevent this, i clamped the texts to a maximum of 3 lines and added a show more button. The buttons should only appear if the text is too long. When the layout changes (eye-> layout -> less cols toggle) the clamp gets recalculated.

Affected sites (please check during review):

  • Index - All cocktail Cards
  • CocktailRecipe Form - there is also the Component used

Signed-off-by: Johannes Groß <mail@gross-johannes.de>
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
@jo-gross jo-gross requested review from jhns-de and fypsilonnn January 9, 2025 14:30
@jo-gross jo-gross linked an issue Jan 9, 2025 that may be closed by this pull request
1 task
@jo-gross jo-gross enabled auto-merge (squash) January 9, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Cocktail card notes, hints and history is sometime too long
1 participant