Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "fickle" to whitelist #87

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Add "fickle" to whitelist #87

merged 1 commit into from
Dec 3, 2024

Conversation

eltoder
Copy link
Contributor

@eltoder eltoder commented Dec 3, 2024

No description provided.

Copy link
Owner

@jo3-l jo3-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'll include this change in the patch release as well, given its minimal size.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (36b6512) to head (12587e0).
Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #87   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        26    -1     
  Lines          505       467   -38     
  Branches        92        80   -12     
=========================================
- Hits           505       467   -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jo3-l jo3-l merged commit da754da into jo3-l:main Dec 3, 2024
9 checks passed
@eltoder eltoder deleted the feature/fickle branch December 3, 2024 00:46
@eltoder
Copy link
Contributor Author

eltoder commented Dec 3, 2024

@jo3-l there's also something called "ficks" (https://www.ficksdrink.com/). maybe we should exclude that as well

And another Fick's https://en.wikipedia.org/wiki/Fick%27s_laws_of_diffusion

@jo3-l
Copy link
Owner

jo3-l commented Dec 3, 2024

Yes, excluding those would also be good but I'm afraid they will have to wait for the next release. You're welcome to send a PR with those additions; I will add them later this month along with the other larger queued changes if not.

(The current whitelist is created from semi-automatic review of a large corpus of English words in the scripts/ directory. It does contain fickle and ducks etc--those are just oversights on my part--but not {fick, ficks}. I wonder if there is a more comprehensive list available somewhere... something for me to look into.)

@eltoder
Copy link
Contributor Author

eltoder commented Dec 3, 2024

@jo3-l Can that process be made fully automatic? I imagine you can run the matcher on all words. If there is a match, you add it into the whitelist of the phrase that matched. Then you pretty-print the result back into the source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants